From issues-return-183601-archive-asf-public=cust-asf.ponee.io@flink.apache.org Thu Aug 9 18:22:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id DB17418078F for ; Thu, 9 Aug 2018 18:22:04 +0200 (CEST) Received: (qmail 95028 invoked by uid 500); 9 Aug 2018 16:22:04 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 95019 invoked by uid 99); 9 Aug 2018 16:22:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Aug 2018 16:22:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 9CA5CC004A for ; Thu, 9 Aug 2018 16:22:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id PAwTGmS9C9iH for ; Thu, 9 Aug 2018 16:22:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 6C2685F525 for ; Thu, 9 Aug 2018 16:22:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DF549E25AA for ; Thu, 9 Aug 2018 16:22:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id A335723FAB for ; Thu, 9 Aug 2018 16:22:00 +0000 (UTC) Date: Thu, 9 Aug 2018 16:22:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-9977) Refine the docs for Table/SQL built-in functions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-9977?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1657= 5087#comment-16575087 ]=20 ASF GitHub Bot commented on FLINK-9977: --------------------------------------- xccui opened a new pull request #6535: [FLINK-9977] [table][doc] Refine the= SQL/Table built-in function docs URL: https://github.com/apache/flink/pull/6535 =20 =20 ## What is the purpose of the change =20 This PR refines the documentation for all the SQL/Table built-in functio= ns. =20 ## Brief change log =20 - Merge the docs for SQL/Table built-in functions into a new separate = page (functions.html). - Rewrite most of the docs to try to make them consistent and correct. - Refine the corresponding test cases in `SqlExpressionTest.scala`. =20 **Note: The old docs about built-in functions in sql.html and tableApi.h= tml should be removed after the new page being verified.** =20 ## Verifying this change =20 This change is a trivial rework / code cleanup without any test coverage= . =20 ## Does this pull request potentially affect one of the following parts: =20 - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(E= volving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its co= mponents), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) =20 ## Documentation =20 - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (docs) =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Refine the docs for Table/SQL built-in functions > ------------------------------------------------ > > Key: FLINK-9977 > URL: https://issues.apache.org/jira/browse/FLINK-9977 > Project: Flink > Issue Type: Improvement > Components: Documentation > Reporter: Xingcan Cui > Assignee: Xingcan Cui > Priority: Minor > Labels: pull-request-available > Attachments: Java.jpg, SQL.jpg, Scala.jpg > > > There exist some syntax errors or inconsistencies in documents and Scala = docs of the Table/SQL built-in functions. This issue aims to make some impr= ovements to them. > Also,=C2=A0according to FLINK-10103, we should use single quotes=C2=A0to = express strings in SQL. For example, CONCAT("AA", "BB", "CC")=C2=A0should b= e replaced with CONCAT('AA', 'BB', 'CC').=C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)