From issues-return-182211-archive-asf-public=cust-asf.ponee.io@flink.apache.org Sat Aug 4 02:35:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 27100180647 for ; Sat, 4 Aug 2018 02:35:02 +0200 (CEST) Received: (qmail 58610 invoked by uid 500); 4 Aug 2018 00:35:02 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 58600 invoked by uid 99); 4 Aug 2018 00:35:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 04 Aug 2018 00:35:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id BBF78C5CB2 for ; Sat, 4 Aug 2018 00:35:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Vj3KHpk2HWr3 for ; Sat, 4 Aug 2018 00:35:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id DC2385F1BD for ; Sat, 4 Aug 2018 00:35:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5AEC5E0026 for ; Sat, 4 Aug 2018 00:35:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 198BB23F99 for ; Sat, 4 Aug 2018 00:35:00 +0000 (UTC) Date: Sat, 4 Aug 2018 00:35:00 +0000 (UTC) From: "Elias Levy (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-9600) Add DataStream transformation variants that pass timestamp to the user function MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-9600?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1656= 8955#comment-16568955 ]=20 Elias Levy commented on FLINK-9600: ----------------------------------- [~aljoscha] I am aware of {{ProcessFunction}}, but I consider it an escape = hatch when you can't perform what you want within the higher level DSL.=C2= =A0 The improvement I am suggestion is within the higher level DSL. E.g.it is a lot nicer to write: {code:java} dataStream.filter( (x, ts) =3D> { isDayTime(ts) } ) {code} than {code:java} class ProcessFilter extends ProcessFunction[T,T] { override def processElement(value: T, ctx: Context, out: Collector[T]): U= nit =3D{ if (isDayTime(ctx.timestamp)) out.collect(value) } } }=C2=A0 dataStream.process(new ProcessFilter()) {code} =C2=A0 > Add DataStream transformation variants that pass timestamp to the user fu= nction > -------------------------------------------------------------------------= ------ > > Key: FLINK-9600 > URL: https://issues.apache.org/jira/browse/FLINK-9600 > Project: Flink > Issue Type: Improvement > Components: Streaming > Affects Versions: 1.5.0 > Reporter: Elias Levy > Priority: Minor > > It is often necessary to access the timestamp assigned to=C2=A0records wi= thin user functions. =C2=A0At the moment this is only possible from {{RichF= unction}}. Implementing a {{RichFunction}} just to access the timestamp is = burdensome, so most job carry a duplicate of the timestamp within the recor= d. > It would be useful if {{DataStream}} provided transformation methods that= accepted user functions that could be passed the record's timestamp as an = additional argument, similar to how there are two variants of {{flatMap}}, = one with an extra parameter that gives the user function access to the outp= ut {{Collector}}. > Along similar lines, it may be useful to have variants that pass the reco= rd's key as an additional parameter. > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)