From issues-return-184970-archive-asf-public=cust-asf.ponee.io@flink.apache.org Thu Aug 16 17:50:17 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E1957180675 for ; Thu, 16 Aug 2018 17:50:16 +0200 (CEST) Received: (qmail 55018 invoked by uid 500); 16 Aug 2018 15:50:16 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 55009 invoked by uid 99); 16 Aug 2018 15:50:16 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Aug 2018 15:50:16 +0000 From: GitBox To: issues@flink.apache.org Subject: [GitHub] buptljy opened a new pull request #6571: [FLINK-10119]- Add failure handlers for JsonRowDeserializationSchema Message-ID: <153443461542.1031.6550500610041566591.gitbox@gitbox.apache.org> Date: Thu, 16 Aug 2018 15:50:15 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit buptljy opened a new pull request #6571: [FLINK-10119]- Add failure handlers for JsonRowDeserializationSchema URL: https://github.com/apache/flink/pull/6571 ## What is the purpose of the change The program will throw runtime exceptions and exit if json messages cannot be parsed correctly, which doesn't make sense to developers because it's very normal for them to receive dirty data from the source. Now we offer format.failure-handler to deal with this kind of json data. 1. "fail": the deserialization will throw an exception. 2. "ignore": the deserialization will return a null value, which will be ignored. 3. "error-field": An additional field will be added into the row to store error messages and the other fields will be null. ## Brief change log * Add format.failure-handler in JsonValidator and failureHandler in Json. * Optimize JsonRowDeserializationSchema to deal with "error" data. * Add unit tests. ## Verifying this change Unit tests. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services