From issues-return-184831-archive-asf-public=cust-asf.ponee.io@flink.apache.org Thu Aug 16 11:38:58 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A574418076D for ; Thu, 16 Aug 2018 11:38:57 +0200 (CEST) Received: (qmail 1070 invoked by uid 500); 16 Aug 2018 09:38:56 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 828 invoked by uid 99); 16 Aug 2018 09:38:56 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Aug 2018 09:38:56 +0000 From: GitBox To: issues@flink.apache.org Subject: [GitHub] pnowojski commented on a change in pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl options Message-ID: <153441233601.3303.2688046460409367525.gitbox@gitbox.apache.org> Date: Thu, 16 Aug 2018 09:38:56 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit pnowojski commented on a change in pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl options URL: https://github.com/apache/flink/pull/6355#discussion_r210515177 ########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyServer.java ########## @@ -152,10 +154,17 @@ void init(final NettyProtocol protocol, NettyBufferPool nettyBufferPool) throws @Override public void initChannel(SocketChannel channel) throws Exception { if (serverSSLContext != null) { - SSLEngine sslEngine = serverSSLContext.createSSLEngine(); + SSLEngine sslEngine = serverSSLContext.sslContext.createSSLEngine(); config.setSSLVerAndCipherSuites(sslEngine); sslEngine.setUseClientMode(false); - channel.pipeline().addLast("ssl", new SslHandler(sslEngine)); + SslHandler sslHandler = new SslHandler(sslEngine); Review comment: `ctrl+v` - please deduplicate this somehow and please do this in this PR, since this is the place where you introduce/make duplication worse. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services