From issues-return-184757-archive-asf-public=cust-asf.ponee.io@flink.apache.org Thu Aug 16 10:07:50 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5102E180675 for ; Thu, 16 Aug 2018 10:07:50 +0200 (CEST) Received: (qmail 93932 invoked by uid 500); 16 Aug 2018 08:07:49 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 93923 invoked by uid 99); 16 Aug 2018 08:07:49 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Aug 2018 08:07:49 +0000 From: GitBox To: issues@flink.apache.org Subject: [GitHub] StefanRRichter commented on a change in pull request #6558: [FLINK-9116] Introduce getAll and removeAll for MapState Message-ID: <153440686883.7291.13045047116223087878.gitbox@gitbox.apache.org> Date: Thu, 16 Aug 2018 08:07:48 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit StefanRRichter commented on a change in pull request #6558: [FLINK-9116] Introduce getAll and removeAll for MapState URL: https://github.com/apache/flink/pull/6558#discussion_r210509235 ########## File path: flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/client/state/ImmutableMapState.java ########## @@ -52,6 +53,16 @@ public V get(K key) { return state.get(key); } + @Override + public Map getAll(Collection keys) { + + Map maps = new HashMap<>(); Review comment: Again init with capacity. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services