From issues-return-183571-archive-asf-public=cust-asf.ponee.io@flink.apache.org Thu Aug 9 17:32:35 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1969618065B for ; Thu, 9 Aug 2018 17:32:34 +0200 (CEST) Received: (qmail 73191 invoked by uid 500); 9 Aug 2018 15:32:34 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 73182 invoked by uid 99); 9 Aug 2018 15:32:34 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Aug 2018 15:32:34 +0000 From: GitBox To: issues@flink.apache.org Subject: =?utf-8?q?=5BGitHub=5D_GJL_commented_on_a_change_in_pull_request_=236294?= =?utf-8?q?=3A_=5BFLINK-9013=5D=5Bdocs=5D_Document_yarn=2Econtainers=2Evco?= =?utf-8?q?res_only_being_effective_whe=E2=80=A6?= Message-ID: <153382875369.27370.465014663037770382.gitbox@gitbox.apache.org> Date: Thu, 09 Aug 2018 15:32:33 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit GJL commented on a change in pull request #6294: [FLINK-9013][docs] Document yarn.containers.vcores only being effective whe… URL: https://github.com/apache/flink/pull/6294#discussion_r208976465 ########## File path: flink-core/src/main/java/org/apache/flink/configuration/description/HtmlFormatter.java ########## @@ -34,9 +36,22 @@ protected void formatLineBreak(StringBuilder state) { } @Override - protected void formatText(StringBuilder state, String format, String[] elements) { + protected void formatText( + StringBuilder state, + String format, + String[] elements, + EnumSet styles) { String escapedFormat = escapeCharacters(format); + + String prefix = ""; + String suffix = ""; + if (styles.contains(TextElement.TextStyle.CODE)) { + prefix = ""; Review comment: `` is not part of the HTML5 standard: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/tt ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services