From issues-return-183066-archive-asf-public=cust-asf.ponee.io@flink.apache.org Tue Aug 7 14:54:12 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D292C180657 for ; Tue, 7 Aug 2018 14:54:11 +0200 (CEST) Received: (qmail 26297 invoked by uid 500); 7 Aug 2018 12:54:11 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 26288 invoked by uid 99); 7 Aug 2018 12:54:10 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Aug 2018 12:54:10 +0000 From: GitBox To: issues@flink.apache.org Subject: [GitHub] zentol commented on issue #6518: [FLINK-10094][tests] Always backup config before running test Message-ID: <153364645037.31347.1487935002894274874.gitbox@gitbox.apache.org> Date: Tue, 07 Aug 2018 12:54:10 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit zentol commented on issue #6518: [FLINK-10094][tests] Always backup config before running test URL: https://github.com/apache/flink/pull/6518#issuecomment-411045645 I believe we do always revert it. ``` # from test-runner-common.sh function cleanup_proc { shutdown_all revert_default_config } trap cleanup_proc EXIT ``` I guess the explicit cleanup in `run_test` could be removed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services