From issues-return-182537-archive-asf-public=cust-asf.ponee.io@flink.apache.org Mon Aug 6 10:50:53 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6E1EE180627 for ; Mon, 6 Aug 2018 10:50:52 +0200 (CEST) Received: (qmail 81846 invoked by uid 500); 6 Aug 2018 08:50:51 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 81837 invoked by uid 99); 6 Aug 2018 08:50:51 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Aug 2018 08:50:51 +0000 From: GitBox To: issues@flink.apache.org Subject: [GitHub] twalthr edited a comment on issue #6282: [FLINK-6847][FLINK-6813] [table] TimestampDiff table api and sql support Message-ID: <153354545099.31326.16993845364424833044.gitbox@gitbox.apache.org> Date: Mon, 06 Aug 2018 08:50:50 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit twalthr edited a comment on issue #6282: [FLINK-6847][FLINK-6813] [table] TimestampDiff table api and sql support URL: https://github.com/apache/flink/pull/6282#issuecomment-410635847 Sorry @xueyumusic you are right. I thought `TIMESTAMPDIFF` is similar to `TIMESTAMPADD`. But actually the parameters and logic are quite different. So yes, we should have a syntax `timestampDiff(TimeIntervalUnit.DAY, '2018-07-03'.toDate, '2018-07-04'.toDate)` instead. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services