flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10259) Key validation for GroupWindowAggregate is broken
Date Fri, 31 Aug 2018 07:36:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16598371#comment-16598371
] 

ASF GitHub Bot commented on FLINK-10259:
----------------------------------------

fhueske opened a new pull request #6641: [FLINK-10259] Fix key extraction for GroupWindows.
URL: https://github.com/apache/flink/pull/6641
 
 
   ## What is the purpose of the change
   
   Fixes the key validation for SQL queries with group window aggregates that are emitted
to an `UpsertStreamTableSink`.
   
   ## Brief change log
   
   * Handle window properties (start, end, rowtime) in one equivalence group because all property
attributes identify the same window.
   * Add tests for SQL `INSERT INTO` of different result types to different types of table
sinks.
   
   ## Verifying this change
   
   * Run the added tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? **n/a**
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Key validation for GroupWindowAggregate is broken
> -------------------------------------------------
>
>                 Key: FLINK-10259
>                 URL: https://issues.apache.org/jira/browse/FLINK-10259
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API &amp; SQL
>            Reporter: Fabian Hueske
>            Assignee: Fabian Hueske
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.6.1, 1.7.0, 1.5.4
>
>
> WindowGroups have multiple equivalent keys (start, end) that should be handled differently
from other keys. The {{UpdatingPlanChecker}} uses equivalence groups to identify equivalent
keys but the keys of WindowGroups are not correctly assigned to groups.
> This means that we cannot correctly extract keys from queries that use group windows.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message