flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "vinoyang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10216) Add REGEXP_MATCH in TableAPI and SQL
Date Mon, 27 Aug 2018 15:57:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593867#comment-16593867
] 

vinoyang commented on FLINK-10216:
----------------------------------

If regexp_match (or other name) maintains the same semantics as similar to, then I support
providing a function that provides the same implementation as similar to, because it seems
similar to satisfy the semantics of the database, but purely based Java's regular matching
can't be done.

> Add REGEXP_MATCH in TableAPI and SQL
> ------------------------------------
>
>                 Key: FLINK-10216
>                 URL: https://issues.apache.org/jira/browse/FLINK-10216
>             Project: Flink
>          Issue Type: Sub-task
>            Reporter: Juho Autio
>            Priority: Major
>
> Here's a naive implementation:
> {code:java}
> public class RegexpMatchFunction extends ScalarFunction {
>     // NOTE! Flink calls eval() by reflection
>     public boolean eval(String value, String pattern) {
>         return value != null && pattern != null && value.matches(pattern);
>     }
> }
> {code}
> I wonder if there would be a way to optimize this to use {{Pattern.compile(value)}} and
use the compiled Pattern for multiple calls (possibly different values, but same pattern).
> h3. Naming
> Should regex functions be prefixed with {{regexp_}} or {{regex_}}? See also: [https://github.com/apache/flink/pull/6448#issuecomment-415972833]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message