flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10193) Default RPC timeout is used when triggering savepoint via JobMasterGateway
Date Wed, 22 Aug 2018 12:27:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588783#comment-16588783
] 

ASF GitHub Bot commented on FLINK-10193:
----------------------------------------

GJL edited a comment on issue #6601: [FLINK-10193] Add @RpcTimeout to JobMasterGateway.triggerSavepoint
URL: https://github.com/apache/flink/pull/6601#issuecomment-415012048
 
 
   I see the following possibilities to unit test this:
   
   1. Override `triggerSavepoint` to a NOP, and trigger savepoint twice with increasing timeouts.
The second invocation should fail later.
   2. Check for presence of the annotation with reflection.
   
   I deliberately did not add tests because Option 1 is slow and depends on
   _"good"_ thread scheduling. Option 2 is fragile and not refactoring friendly.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Default RPC timeout is used when triggering savepoint via JobMasterGateway
> --------------------------------------------------------------------------
>
>                 Key: FLINK-10193
>                 URL: https://issues.apache.org/jira/browse/FLINK-10193
>             Project: Flink
>          Issue Type: Bug
>          Components: Distributed Coordination
>    Affects Versions: 1.5.3, 1.6.0, 1.7.0
>            Reporter: Gary Yao
>            Assignee: Gary Yao
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 1.6.1, 1.7.0, 1.5.4
>
>         Attachments: SlowToCheckpoint.java
>
>
> When calling {{JobMasterGateway#triggerSavepoint(String, boolean, Time)}}, the default
timeout is used because the time parameter of the method  is not annotated with {{@RpcTimeout}}.

> *Expected behavior*
> * timeout for the RPC should be {{RpcUtils.INF_TIMEOUT}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message