flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10174) getbytes with no charsets test error for hex and toBase64
Date Mon, 20 Aug 2018 08:13:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585599#comment-16585599
] 

ASF GitHub Bot commented on FLINK-10174:
----------------------------------------

twalthr commented on a change in pull request #6579: [FLINK-10174][table] fix getbytes in
hex and toBase64
URL: https://github.com/apache/flink/pull/6579#discussion_r211173908
 
 

 ##########
 File path: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala
 ##########
 @@ -563,6 +570,13 @@ class ScalarFunctionsTest extends ScalarTypesTestBase {
       "f33.fromBase64()",
       "FROM_BASE64(f33)",
       "null")
+
+    testAllApis(
+      "5L2g5aW9".fromBase64(),
 
 Review comment:
   Actually, this looks correct for me. It's weird that MySQL returns `e4bda0e5a5bd` for this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> getbytes with no charsets test error for hex and toBase64
> ---------------------------------------------------------
>
>                 Key: FLINK-10174
>                 URL: https://issues.apache.org/jira/browse/FLINK-10174
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API &amp; SQL
>            Reporter: xueyu
>            Assignee: xueyu
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> Hex and toBase64 builtin method use str.getBytes() with no Charset. It maybe depend on
local execution environment for special Unicode and maybe result in errors when test Hex for
special Unicode



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message