flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10170) Support string representation for map types in descriptor-based Table API
Date Sun, 19 Aug 2018 14:54:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16585166#comment-16585166
] 

ASF GitHub Bot commented on FLINK-10170:
----------------------------------------

tragicjun opened a new pull request #6578: [FLINK-10170 [table] Support string representation
for map types in d…
URL: https://github.com/apache/flink/pull/6578
 
 
   ## What is the purpose of the change
   
   Since 1.6 the recommended way of creating source/sink table is using connector/format/schema/
descriptors. However, when declaring map types in the schema descriptor, the following exception
would be thrown:
   
   > org.apache.flink.table.api.TableException: A string representation for map types is
not supported yet.
   
   This pull request is to add string representation support for map types.
   
   ## Brief change log
   
   - Add new `Keyword` and `PackratParser` for map types in TypeStringUtils
   - Add normalization logic for map types in `TypeStringUtils.writeTypeInfo()`
   - Update relevant unit tests in `TypeStringUtilsTest` and `TableDescriptorTest`
   
   ## Verifying this change
   
   This change can be verified  covered by updated unit tests, such as *TypeStringUtilsTest*
and *TableDescriptorTest*.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Support string representation for map types in descriptor-based Table API
> -------------------------------------------------------------------------
>
>                 Key: FLINK-10170
>                 URL: https://issues.apache.org/jira/browse/FLINK-10170
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API &amp; SQL
>    Affects Versions: 1.6.1, 1.7.0
>            Reporter: Jun Zhang
>            Assignee: Jun Zhang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>         Attachments: flink-10170
>
>
> Since 1.6 the recommended way of creating source/sink table is using connector/format/schema/
descriptors. However, when declaring map types in the schema descriptor, the following exception
would be thrown:
> {quote}org.apache.flink.table.api.TableException: A string representation for map types
is not supported yet.{quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message