flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10142) Reduce synchronization overhead for credit notifications
Date Tue, 21 Aug 2018 15:05:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16587560#comment-16587560
] 

ASF GitHub Bot commented on FLINK-10142:
----------------------------------------

NicoK commented on a change in pull request #6555: [FLINK-10142][network] reduce locking around
credit notification
URL: https://github.com/apache/flink/pull/6555#discussion_r211641938
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedPartitionRequestClientHandler.java
 ##########
 @@ -357,19 +357,20 @@ private void writeAndFlushNextMessageIfPossible(Channel channel) {
 				return;
 			}
 
-			//It is no need to notify credit for the released channel.
-			if (!inputChannel.isReleased()) {
-				AddCredit msg = new AddCredit(
-					inputChannel.getPartitionId(),
-					inputChannel.getAndResetUnannouncedCredit(),
-					inputChannel.getInputChannelId());
+			if (inputChannel.isReleased()) {
 
 Review comment:
   irrelevant - that's an artefact of the backport of this patch to the plain 1.5 branch;
I'll revert

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Reduce synchronization overhead for credit notifications
> --------------------------------------------------------
>
>                 Key: FLINK-10142
>                 URL: https://issues.apache.org/jira/browse/FLINK-10142
>             Project: Flink
>          Issue Type: Bug
>          Components: Network
>    Affects Versions: 1.5.2, 1.6.0, 1.7.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Major
>              Labels: pull-request-available
>
> When credit-based flow control was introduced, we also added some checks and optimisations
for uncommon code paths that make common code paths unnecessarily more expensive, e.g. checking
whether a channel was released before forwarding a credit notification to Netty. Such checks
would have to be confirmed by the Netty thread anyway and thus only add additional load for
something that happens only once (per channel).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message