flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10123) Use ExecutorThreadFactory instead of DefaultThreadFactory in RestServer/Client
Date Tue, 14 Aug 2018 06:12:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579304#comment-16579304
] 

ASF GitHub Bot commented on FLINK-10123:
----------------------------------------

yanghua commented on issue #6539: [FLINK-10123] Use ExecutorThreadFactory instead of DefaultThreadFactory
in RestServer/Client
URL: https://github.com/apache/flink/pull/6539#issuecomment-412765241
 
 
   checkstyle error : 
   
   ```
   08:33:28.933 [ERROR] src/test/java/org/apache/flink/test/recovery/JobManagerHACheckpointRecoveryITCase.java:[22]
(imports) ImportOrder: Import org.apache.flink.api.common.functions.RichFlatMapFunction appears
after other imports that it should precede
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Use ExecutorThreadFactory instead of DefaultThreadFactory in RestServer/Client
> ------------------------------------------------------------------------------
>
>                 Key: FLINK-10123
>                 URL: https://issues.apache.org/jira/browse/FLINK-10123
>             Project: Flink
>          Issue Type: Improvement
>          Components: REST
>    Affects Versions: 1.6.0, 1.7.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> Instead of using the {{DefaultThreadFactory}} in the {{RestServerEndpoint}}/{{RestClient}}
we should use the {{ExecutorThreadFactory}} because it uses the {{FatalExitExceptionHandler}}
per default as the uncaught exception handler. This should guard against uncaught exceptions
by simply terminating the JVM.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message