flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10123) Use ExecutorThreadFactory instead of DefaultThreadFactory in RestServer/Client
Date Fri, 10 Aug 2018 15:23:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576433#comment-16576433
] 

ASF GitHub Bot commented on FLINK-10123:
----------------------------------------

tillrohrmann opened a new pull request #6539: [FLINK-10123] Use ExecutorThreadFactory instead
of DefaultThreadFactory in RestServer/Client
URL: https://github.com/apache/flink/pull/6539
 
 
   ## What is the purpose of the change
   
   Using the ExecutorThreadFactory hardens the system because it uses the FatalExitExceptionHandler
   as UncaughtExceptionHandler which terminates the JVM in case of an exception.
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Use ExecutorThreadFactory instead of DefaultThreadFactory in RestServer/Client
> ------------------------------------------------------------------------------
>
>                 Key: FLINK-10123
>                 URL: https://issues.apache.org/jira/browse/FLINK-10123
>             Project: Flink
>          Issue Type: Improvement
>          Components: REST
>    Affects Versions: 1.6.0, 1.7.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> Instead of using the {{DefaultThreadFactory}} in the {{RestServerEndpoint}}/{{RestClient}}
we should use the {{ExecutorThreadFactory}} because it uses the {{FatalExitExceptionHandler}}
per default as the uncaught exception handler. This should guard against uncaught exceptions
by simply terminating the JVM.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message