flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10061) Fix unsupported reconfiguration in KafkaTableSink
Date Mon, 06 Aug 2018 12:40:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570156#comment-16570156
] 

ASF GitHub Bot commented on FLINK-10061:
----------------------------------------

tragicjun commented on a change in pull request #6495: [FLINK-10061] [table] [kafka] Fix unsupported
reconfiguration in KafkaTableSink
URL: https://github.com/apache/flink/pull/6495#discussion_r207876429
 
 

 ##########
 File path: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSink.java
 ##########
 @@ -166,8 +167,17 @@ public void emitDataStream(DataStream<Row> dataStream) {
 	@Override
 	public KafkaTableSink configure(String[] fieldNames, TypeInformation<?>[] fieldTypes)
{
 		if (schema.isPresent()) {
-			// a fixed schema is defined so reconfiguration is not supported
-			throw new UnsupportedOperationException("Reconfiguration of this sink is not supported.");
+			if (getFieldTypes().length != fieldTypes.length || !Arrays.deepEquals(getFieldTypes(),
fieldTypes)) {
+				String fixedFieldTypes = Arrays.deepToString(Arrays.stream(getFieldTypes())
+						.map(s -> s.getTypeClass().getSimpleName()).toArray());
 
 Review comment:
   The if statement uses `Arrays.deepEquals()` which is a clean way of comparing arrays. The
`Arrays.deepToString()` is just used to build string representation of fieldTypes that are
reflected in the exception message. Perhaps the code employs too many **Arrays**, please review
it a bit closer :) 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fix unsupported reconfiguration in KafkaTableSink
> -------------------------------------------------
>
>                 Key: FLINK-10061
>                 URL: https://issues.apache.org/jira/browse/FLINK-10061
>             Project: Flink
>          Issue Type: Bug
>          Components: Kafka Connector
>    Affects Versions: 1.6.0
>            Reporter: Jun Zhang
>            Assignee: Jun Zhang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.6.1, 1.7.0
>
>
> When using KafkaTableSink in "table.writeToSink(), the following exception is thrown:
> {quote} java.lang.UnsupportedOperationException: Reconfiguration of this sink is not
supported.
> {quote}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message