flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10010) Deprecate unused BaseAlignedWindowAssigner related components
Date Thu, 02 Aug 2018 04:46:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566338#comment-16566338
] 

ASF GitHub Bot commented on FLINK-10010:
----------------------------------------

yanghua commented on a change in pull request #6471: [FLINK-10010][DataStream API] Deprecate
unused BaseAlignedWindowAssigner related components
URL: https://github.com/apache/flink/pull/6471#discussion_r207100012
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/BaseAlignedWindowAssigner.java
 ##########
 @@ -27,15 +27,13 @@
 import java.util.Collection;
 
 /**
- * A base {@link WindowAssigner} used to instantiate one of the deprecated
- * {@link org.apache.flink.streaming.runtime.operators.windowing.AccumulatingProcessingTimeWindowOperator
- * AccumulatingProcessingTimeWindowOperator} and
- * {@link org.apache.flink.streaming.runtime.operators.windowing.AggregatingProcessingTimeWindowOperator
- * AggregatingProcessingTimeWindowOperator}.
+ * A base {@link WindowAssigner} used to instantiate one of the deprecated operators.
  *
- * <p>For assigner that extend this one, the user can check the
- * {@link TumblingAlignedProcessingTimeWindows} and the {@link SlidingAlignedProcessingTimeWindows}.
+ * @deprecated will be removed in a future version. please use other {@link WindowAssigner}s
listed under
+ *  * {@link org.apache.flink.streaming.api.windowing.assigners}.
  * */
 
 Review comment:
   replace '* */' to '*/'

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Deprecate unused BaseAlignedWindowAssigner related components
> -------------------------------------------------------------
>
>                 Key: FLINK-10010
>                 URL: https://issues.apache.org/jira/browse/FLINK-10010
>             Project: Flink
>          Issue Type: Bug
>          Components: DataStream API
>            Reporter: Rong Rong
>            Assignee: Rong Rong
>            Priority: Major
>              Labels: pull-request-available
>
> {{BaseAlignedWindowAssigner}} should be marked as deprecated and {{SlidingAlignedProcessingTimeWindows}}
should be removed from the Flink Repo.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message