flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9986) Remove unnecessary information from .version.properties file
Date Mon, 06 Aug 2018 11:29:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570071#comment-16570071
] 

ASF GitHub Bot commented on FLINK-9986:
---------------------------------------

zentol edited a comment on issue #6443:  [FLINK-9986][build] Only include commit info in .version.properties
file 
URL: https://github.com/apache/flink/pull/6443#issuecomment-410677389
 
 
   @StephanEwen The error that you currently should get is
   ```
   [ERROR] Failed to execute goal pl.project13.maven:git-commit-id-plugin:2.1.14:revision
(default) on project flink-runtime_2.11: The plugin pl.project13.maven:git-commit-id-plugin:2.1.14
requires Maven version [3.1.1,) -> [Help 1]
   ```
   
   This is effectively what the enforcer would print as well, albeit later.
   
   When I merged this I was unaware that this bumps the minimum maven version. If we'd bump
the plugin version further to 2.2.4 we would regain support for maven 3.0.X (see https://github.com/ktoso/maven-git-commit-id-plugin/releases/tag/v2.2.4).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Remove unnecessary information from .version.properties file
> ------------------------------------------------------------
>
>                 Key: FLINK-9986
>                 URL: https://issues.apache.org/jira/browse/FLINK-9986
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>    Affects Versions: 1.4.2, 1.5.1, 1.6.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.5.3, 1.6.0
>
>
> To log the revision {{flink-runtime}} creates a {{.version.properties}} file using the
{{git-commit-id-plugin}} that is stored within the jar.
> Here's an example:
> {code}
> git.commit.id.abbrev=1a9b648
> git.commit.user.email=chesnay@apache.org
> git.commit.message.full=Commit for release 1.5.2\n
> git.commit.id=1a9b6486a2d268d4fb8282c32d65fcc701d18e42
> git.commit.message.short=Commit for release 1.5.2
> git.commit.user.name=zentol
> git.build.user.name=zentol
> git.build.user.email=chesnay@apache.org
> git.branch=1a9b6486a2d268d4fb8282c32d65fcc701d18e42
> git.commit.time=25.07.2018 @ 17\:10\:13 GMT
> git.build.time=25.07.2018 @ 20\:47\:15 GMT
> git.remote.origin.url=https\://github.com/zentol/flink.git
> {code}
> most of this information isn't used, as flink-runtime only access {{git.commit.id.abbrev}}
and {{git.commit.time}}.
> The build, remote and branch information should be removed as they are neither relevant,
nor consistent, as releases can be created on any branch, under any git alias, against any
remote.
> To exclude properties we have to bump the plugin version to 2.1.9.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message