flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9977) Refine the docs for Table/SQL built-in functions
Date Thu, 09 Aug 2018 16:22:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16575087#comment-16575087
] 

ASF GitHub Bot commented on FLINK-9977:
---------------------------------------

xccui opened a new pull request #6535: [FLINK-9977] [table][doc] Refine the SQL/Table built-in
function docs
URL: https://github.com/apache/flink/pull/6535
 
 
   ## What is the purpose of the change
   
   This PR refines the documentation for all the SQL/Table built-in functions.
   
   ## Brief change log
   
     - Merge the docs for SQL/Table built-in functions into a new separate page (functions.html).
     - Rewrite most of the docs to try to make them consistent and correct.
     - Refine the corresponding test cases in `SqlExpressionTest.scala`.
   
   **Note: The old docs about built-in functions in sql.html and tableApi.html should be removed
after the new page being verified.**
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (docs)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Refine the docs for Table/SQL built-in functions
> ------------------------------------------------
>
>                 Key: FLINK-9977
>                 URL: https://issues.apache.org/jira/browse/FLINK-9977
>             Project: Flink
>          Issue Type: Improvement
>          Components: Documentation
>            Reporter: Xingcan Cui
>            Assignee: Xingcan Cui
>            Priority: Minor
>              Labels: pull-request-available
>         Attachments: Java.jpg, SQL.jpg, Scala.jpg
>
>
> There exist some syntax errors or inconsistencies in documents and Scala docs of the
Table/SQL built-in functions. This issue aims to make some improvements to them.
> Also, according to FLINK-10103, we should use single quotes to express strings in SQL.
For example, CONCAT("AA", "BB", "CC") should be replaced with CONCAT('AA', 'BB', 'CC'). 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message