flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9938) State TTL cleanup during full state scan upon checkpointing
Date Wed, 01 Aug 2018 12:38:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16565225#comment-16565225
] 

ASF GitHub Bot commented on FLINK-9938:
---------------------------------------

StefanRRichter commented on a change in pull request #6460: [FLINK-9938] Clean up full snapshot
from expired state with TTL
URL: https://github.com/apache/flink/pull/6460#discussion_r206819726
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/NestedMapsStateTable.java
 ##########
 @@ -330,9 +332,14 @@ public int sizeOfNamespace(Object namespace) {
 	static class NestedMapsStateTableSnapshot<K, N, S>
 			extends AbstractStateTableSnapshot<K, N, S, NestedMapsStateTable<K, N, S>>
 			implements StateSnapshot.StateKeyGroupWriter {
+		private final TypeSerializer<K> keySerializer = owningStateTable.keyContext.getKeySerializer();
 
 Review comment:
   Whenever possible, I would suggest to initialize fields in the constructor and not inline.
What is even the purpose of this change, because it looks unrelated and the improvement is
not clear to me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> State TTL cleanup during full state scan upon checkpointing
> -----------------------------------------------------------
>
>                 Key: FLINK-9938
>                 URL: https://issues.apache.org/jira/browse/FLINK-9938
>             Project: Flink
>          Issue Type: Improvement
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.6.0
>            Reporter: Andrey Zagrebin
>            Assignee: Andrey Zagrebin
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>
> We can try to piggyback full state scan during certain checkpoint processes in backends,
check TTL expiration for every entry and evict expired to speed up cleanup.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message