flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9913) Improve output serialization only once in RecordWriter
Date Mon, 13 Aug 2018 10:06:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578048#comment-16578048
] 

ASF GitHub Bot commented on FLINK-9913:
---------------------------------------

zhijiangW commented on issue #6417: [FLINK-9913][runtime] Improve output serialization only
once in RecordWriter
URL: https://github.com/apache/flink/pull/6417#issuecomment-412469613
 
 
   @pnowojski , thanks for your reviews!
   I basically agree with your idea of separating current `RecordSerializer` further, but
consider specific implementation, there are still some issues to be confirmed. After we reach
the agreement, I will continue with the test issues. :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Improve output serialization only once in RecordWriter
> ------------------------------------------------------
>
>                 Key: FLINK-9913
>                 URL: https://issues.apache.org/jira/browse/FLINK-9913
>             Project: Flink
>          Issue Type: Improvement
>          Components: Network
>    Affects Versions: 1.6.0
>            Reporter: zhijiang
>            Assignee: zhijiang
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> Currently the {{RecordWriter}} emits output into multi channels via {{ChannelSelector}} 
or broadcasts output to all channels directly. Each channel has a separate {{RecordSerializer}}
for serializing outputs, that means the output will be serialized as many times as the number
of selected channels.
> As we know, data serialization is a high cost operation, so we can get good benefits
by improving the serialization only once.
> I would suggest the following changes for realizing it.
>  # Only one {{RecordSerializer}} is created in {{RecordWriter}} for all the channels.
>  # The output is serialized into the intermediate data buffer only once for different
channels.
>  # The intermediate serialization results are copied into different {{BufferBuilder}}s
for different channels.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message