flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9713) Support versioned joins in planning phase
Date Wed, 08 Aug 2018 11:30:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573051#comment-16573051
] 

ASF GitHub Bot commented on FLINK-9713:
---------------------------------------

twalthr commented on a change in pull request #6299: [FLINK-9713][table][sql] Support processing
time versioned joins
URL: https://github.com/apache/flink/pull/6299#discussion_r208502190
 
 

 ##########
 File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
 ##########
 @@ -155,6 +158,90 @@ class Table(
     select(withResolvedAggFunctionCall: _*)
   }
 
+  /**
+    * Creates table version function backed up by this table as a history table.
+    *
+    * @param version field for the [[TableVersionFunction]]. Must points to a time indicator
+    * @param primaryKey field for the [[TableVersionFunction]].
+    * @return [[TableVersionFunction]]
+    */
+  def createTableVersionFunction(
+      version: String,
+      primaryKey: String): TableVersionFunction = {
+    createTableVersionFunction(
+      ExpressionParser.parseExpression(version),
+      ExpressionParser.parseExpression(primaryKey))
+  }
+
+  /**
+    * Creates table version function backed up by this table as a history table.
+    *
+    * @param version field for the [[TableVersionFunction]]. Must points to a time indicator
+    * @param primaryKey field for the [[TableVersionFunction]].
+    * @return [[TableVersionFunction]]
+    */
+  def createTableVersionFunction(
+      version: Expression,
+      primaryKey: Expression): TableVersionFunction = {
+    val (versionField, isProctime) = validateVersionExpression(version)
+    TableVersionFunction.create(
+      this,
+      versionField,
+      validatePrimaryKeyExpression(primaryKey),
+      isProctime)
+  }
+
+  private def validateVersionExpression(expression: Expression): (String, Boolean) = {
+    expression match {
+      case rowtime: RowtimeAttribute =>
 
 Review comment:
   The expressions `RowtimeAttribute` and `ProctimeAttribute` should only be used when converting
a DataStream to a table. The validation should happen at a later stage when fields are resolved.
Proper time attributes can only be check during translation for now (I agree this is ugly.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Support versioned joins in planning phase
> -----------------------------------------
>
>                 Key: FLINK-9713
>                 URL: https://issues.apache.org/jira/browse/FLINK-9713
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API &amp; SQL
>    Affects Versions: 1.5.0
>            Reporter: Piotr Nowojski
>            Assignee: Piotr Nowojski
>            Priority: Major
>              Labels: pull-request-available
>
> Queries like:
> {code:java}
> SELECT 
>   o.amount * r.rate 
> FROM 
>   Orders AS o, 
>   LATERAL TABLE (Rates(o.rowtime)) AS r 
> WHERE o.currency = r.currency{code}
> should evaluate to valid plan with versioned joins plan node.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message