flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9546) The heartbeatTimeoutIntervalMs of HeartbeatMonitor should be larger than 0
Date Wed, 15 Aug 2018 15:31:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581235#comment-16581235
] 

ASF GitHub Bot commented on FLINK-9546:
---------------------------------------

asfgit closed pull request #6135: [FLINK-9546][core] Fix the checking of heartbeatTimeoutIntervalMs
in HeartbeatMonitor.
URL: https://github.com/apache/flink/pull/6135
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatManagerImpl.java
b/flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatManagerImpl.java
index 42268fc46e7..242fbaa086a 100644
--- a/flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatManagerImpl.java
+++ b/flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatManagerImpl.java
@@ -277,7 +277,7 @@ public void requestHeartbeat(final ResourceID requestOrigin, I heartbeatPayload)
 			this.scheduledExecutor = Preconditions.checkNotNull(scheduledExecutor);
 			this.heartbeatListener = Preconditions.checkNotNull(heartbeatListener);
 
-			Preconditions.checkArgument(heartbeatTimeoutIntervalMs >= 0L, "The heartbeat timeout
interval has to be larger than 0.");
+			Preconditions.checkArgument(heartbeatTimeoutIntervalMs > 0L, "The heartbeat timeout
interval has to be larger than 0.");
 			this.heartbeatTimeoutIntervalMs = heartbeatTimeoutIntervalMs;
 
 			lastHeartbeat = 0L;


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> The heartbeatTimeoutIntervalMs of HeartbeatMonitor should be larger than 0
> --------------------------------------------------------------------------
>
>                 Key: FLINK-9546
>                 URL: https://issues.apache.org/jira/browse/FLINK-9546
>             Project: Flink
>          Issue Type: Bug
>          Components: Core
>            Reporter: Sihua Zhou
>            Assignee: Sihua Zhou
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> The heartbeatTimeoutIntervalMs of HeartbeatMonitor should be larger than 0, currently
the arg check looks like
> {code:java}
> Preconditions.checkArgument(heartbeatTimeoutIntervalMs >= 0L, "The heartbeat timeout
interval has to be larger than 0.");
> {code}
> it should be
> {code:java}
> Preconditions.checkArgument(heartbeatTimeoutIntervalMs > 0L, "The heartbeat timeout
interval has to be larger than 0.");
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message