flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6895) Add STR_TO_DATE supported in SQL
Date Wed, 15 Aug 2018 06:35:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16580765#comment-16580765
] 

ASF GitHub Bot commented on FLINK-6895:
---------------------------------------

buptljy commented on a change in pull request #6359: [FLINK-6895][table]Add STR_TO_DATE supported
in SQL
URL: https://github.com/apache/flink/pull/6359#discussion_r210181419
 
 

 ##########
 File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/StrToDateCallGen.scala
 ##########
 @@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.codegen.calls
+
+import org.apache.flink.api.common.typeinfo.SqlTimeTypeInfo
+import org.apache.flink.table.codegen.calls.CallGenerator.generateCallIfArgsNotNull
+import org.apache.flink.table.codegen.{CodeGenerator, GeneratedExpression}
+import org.apache.flink.table.runtime.functions.DateTimeFunctions
+
+/**
+  * Generates StrToDate call based on the type of last operand.
+  */
+class StrToDateCallGen extends CallGenerator {
+  override def generate(codeGenerator: CodeGenerator,
+                        operands: Seq[GeneratedExpression]): GeneratedExpression = {
+    if (operands.last.literal) {
 
 Review comment:
   @twalthr Thanks for pointing it out. But we don't have the problem here, because I wrote
ScalarSqlFunctionReturnTypes to return different types according to operands types, which
is supported by Calcite.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add STR_TO_DATE supported in SQL
> --------------------------------
>
>                 Key: FLINK-6895
>                 URL: https://issues.apache.org/jira/browse/FLINK-6895
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API &amp; SQL
>    Affects Versions: 1.4.0
>            Reporter: sunjincheng
>            Assignee: buptljy
>            Priority: Major
>              Labels: pull-request-available
>
> STR_TO_DATE(str,format) This is the inverse of the DATE_FORMAT() function. It takes a
string str and a format string format. STR_TO_DATE() returns a DATETIME value if the format
string contains both date and time parts, or a DATE or TIME value if the string contains only
date or time parts. If the date, time, or datetime value extracted from str is illegal, STR_TO_DATE()
returns NULL and produces a warning.
> * Syntax:
> STR_TO_DATE(str,format) 
> * Arguments
> **str: -
> **format: -
> * Return Types
>   DATAETIME/DATE/TIME
> * Example:
>   STR_TO_DATE('01,5,2013','%d,%m,%Y') -> '2013-05-01'
>   SELECT STR_TO_DATE('a09:30:17','a%h:%i:%s') -> '09:30:17'
> * See more:
> ** [MySQL| https://dev.mysql.com/doc/refman/5.7/en/date-and-time-functions.html#function_str-to-date]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message