flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chesnay Schepler (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (FLINK-6670) Remove CommonTestUtils.createTempDirectory()
Date Mon, 20 Aug 2018 15:38:00 GMT

     [ https://issues.apache.org/jira/browse/FLINK-6670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chesnay Schepler closed FLINK-6670.
-----------------------------------
       Resolution: Fixed
    Fix Version/s: 1.7.0

master: 70e1a5e6f9d85a84c251a5f66712c87944e52899

> Remove CommonTestUtils.createTempDirectory()
> --------------------------------------------
>
>                 Key: FLINK-6670
>                 URL: https://issues.apache.org/jira/browse/FLINK-6670
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>            Reporter: Nico Kruber
>            Assignee: Chesnay Schepler
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> {{CommonTestUtils.createTempDirectory()}} encourages a dangerous design pattern with
potential concurrency issues in the unit tests as well as the need to cleanup the created
directories.
> Instead, it should be solved by using the following pattern:
> {code:java}
>         @Rule
>         public TemporaryFolder tempFolder = new TemporaryFolder();
> {code}
> We should therefore remove {{CommonTestUtils.createTempDirectory()}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message