flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] pnowojski commented on issue #6577: [FLINK-7964] Add Apache Kafka 1.0/1.1 connectors
Date Wed, 22 Aug 2018 08:26:03 GMT
pnowojski commented on issue #6577: [FLINK-7964] Add Apache Kafka 1.0/1.1 connectors
URL: https://github.com/apache/flink/pull/6577#issuecomment-414953729
 
 
   Yes, I missed those changes.
   
   Btw, don't get me wrong, with "depressing" I wasn't complaining about this contribution,
since it's fully following already established pattern :) Also by me, since when I was creating
`0.11` connector, I only refactored/deduplicated producer side of the tests and copied/pasted
most of the consumer side tests.
   
   Regarding the @aljoscha 's comment, I will clarify this, since the issues that he mentioned/referred
was a little bit irrelevant to question whether we need another module if our client is forward
compatible (if it's able to talk to newer Kafka servers).  FLINK-9690/FLINK-9700 were/are
about incompatibilities of our `0.11` connector when compiling it against Kafka `1.0` or `1.1`.
That's something else.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message