flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] pnowojski commented on a change in pull request #6574: [FLINK-8868] [table] Support Table Function as Table Source for Stream Sql
Date Wed, 22 Aug 2018 08:13:32 GMT
pnowojski commented on a change in pull request #6574: [FLINK-8868] [table] Support Table Function
as Table Source for Stream Sql
URL: https://github.com/apache/flink/pull/6574#discussion_r211865010
 
 

 ##########
 File path: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/SqlITCase.scala
 ##########
 @@ -897,6 +897,45 @@ class SqlITCase extends StreamingWithStateTestBase {
 
     assertEquals(List(expected.toString()), StreamITCase.testResults.sorted)
   }
+
+  @Test
 
 Review comment:
   Sorry, I meant the other way around. We should try to fix this for table api. By saying:
   >  I would expect there to have this error:
   
   I didn't mean that "I would like to have test asserting this validation exception", but
"I think you missed testing this feature on table API and it probably will fail there with
validation exception"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message