flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] fhueske commented on issue #6585: [FLINK-10172][table]re-adding asc & desc suffix expression to expressionParser
Date Wed, 22 Aug 2018 07:17:56 GMT
fhueske commented on issue #6585: [FLINK-10172][table]re-adding asc & desc suffix expression
to expressionParser
URL: https://github.com/apache/flink/pull/6585#issuecomment-414936045
 
 
   `asc` and `desc` are not regular functions. They are indicators for the sort order and
converted into special `Ordering` expressions. Without special treatment, they are converted
into `Call("asc", fieldRef)` and therefore not correctly handled by `Table.orderBy()` which
expects `Ordering` expressions.
   
   This PR adds code that was (accidentially?) dropped when refactoring the `ExpressionParser`
in 9244106b334ef54ba3e39a3f2c0c76f46ae4ecd3.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message