flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] pnowojski commented on a change in pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl options
Date Thu, 16 Aug 2018 09:38:56 GMT
pnowojski commented on a change in pull request #6355: [FLINK-9878][network][ssl] add more
low-level ssl options
URL: https://github.com/apache/flink/pull/6355#discussion_r210515177
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyServer.java
 ##########
 @@ -152,10 +154,17 @@ void init(final NettyProtocol protocol, NettyBufferPool nettyBufferPool)
throws
 			@Override
 			public void initChannel(SocketChannel channel) throws Exception {
 				if (serverSSLContext != null) {
-					SSLEngine sslEngine = serverSSLContext.createSSLEngine();
+					SSLEngine sslEngine = serverSSLContext.sslContext.createSSLEngine();
 					config.setSSLVerAndCipherSuites(sslEngine);
 					sslEngine.setUseClientMode(false);
-					channel.pipeline().addLast("ssl", new SslHandler(sslEngine));
+					SslHandler sslHandler = new SslHandler(sslEngine);
 
 Review comment:
   `ctrl+v` - please deduplicate this somehow and please do this in this PR, since this is
the place where you introduce/make duplication worse.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message