flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] zentol commented on a change in pull request #6551: [FLINK-10022][network][metrics] add metrics for input/output buffers
Date Tue, 14 Aug 2018 10:44:46 GMT
zentol commented on a change in pull request #6551: [FLINK-10022][network][metrics] add metrics
for input/output buffers
URL: https://github.com/apache/flink/pull/6551#discussion_r209906457
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/IOMetrics.java
 ##########
 @@ -43,38 +43,74 @@
 	protected double numBytesInRemotePerSecond;
 	protected double numBytesOutPerSecond;
 
-	public IOMetrics(Meter recordsIn, Meter recordsOut, Meter bytesLocalIn, Meter bytesRemoteIn,
Meter bytesOut) {
+	protected long numBuffersInLocal;
+	protected long numBuffersInRemote;
+	protected long numBuffersOut;
+
+	protected double numBuffersInLocalPerSecond;
+	protected double numBuffersInRemotePerSecond;
+	protected double numBuffersOutPerSecond;
+
+	public IOMetrics(
 
 Review comment:
   so this here is really the big question mark for me. So far we only kept metrics in here
that are displayed in the UI, but with this PR we'd break that. This is mostly done to have
accurate displays at the end of the job, which in particular in the case of batch jobs is
important.
   
   The question is, do we truly need 100% accurate buffer metrics here? For _debugging_ purposes
there are always other avenues one can take to get accurate readings. (delay shutdown of job
until metrics are updated)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message