flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] yanghua commented on issue #6367: [FLINK-9850] Add a string to the print method to identify output for DataStream
Date Fri, 10 Aug 2018 17:02:09 GMT
yanghua commented on issue #6367: [FLINK-9850] Add a string to the print method to identify
output for DataStream
URL: https://github.com/apache/flink/pull/6367#issuecomment-412144209
 
 
   Hi @pnowojski thanks for your suggestion, I have refactored this PR, we both changed the
`PrintSinkFunctionTest` so maybe I did not finish all of the works. What's more, I agree with
the opinion about "deduplicate the logic of PrintSinkFunction and PrintingOutputFormat", 
I'd like to start this work, if current issue would be fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message