flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] GJL commented on a change in pull request #6294: [FLINK-9013][docs] Document yarn.containers.vcores only being effective whe…
Date Thu, 09 Aug 2018 15:32:33 GMT
GJL commented on a change in pull request #6294: [FLINK-9013][docs] Document yarn.containers.vcores
only being effective whe…
URL: https://github.com/apache/flink/pull/6294#discussion_r208976465
 
 

 ##########
 File path: flink-core/src/main/java/org/apache/flink/configuration/description/HtmlFormatter.java
 ##########
 @@ -34,9 +36,22 @@ protected void formatLineBreak(StringBuilder state) {
 	}
 
 	@Override
-	protected void formatText(StringBuilder state, String format, String[] elements) {
+	protected void formatText(
+			StringBuilder state,
+			String format,
+			String[] elements,
+			EnumSet<TextElement.TextStyle> styles) {
 		String escapedFormat = escapeCharacters(format);
+
+		String prefix = "";
+		String suffix = "";
+		if (styles.contains(TextElement.TextStyle.CODE)) {
+			prefix = "<tt>";
 
 Review comment:
   `<tt>` is not part of the HTML5 standard: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/tt

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message