flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] yanghua commented on a change in pull request #6522: [FLINK-10101][mesos] Add web ui url for mesos.
Date Thu, 09 Aug 2018 06:29:50 GMT
yanghua commented on a change in pull request #6522: [FLINK-10101][mesos] Add web ui url for
mesos.
URL: https://github.com/apache/flink/pull/6522#discussion_r208818211
 
 

 ##########
 File path: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManager.java
 ##########
 @@ -120,6 +120,9 @@
 	/** A local actor system for using the helper actors. */
 	private final ActorSystem actorSystem;
 
+	/** Web url for to show in mesos page.*/
+	@Nullable private final String webUiUrl;
 
 Review comment:
   for field, I recommend `@Nullable` to move up one line

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message