flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] twalthr commented on a change in pull request #6484: [FLINK-9134] [table] upgrade Calcite dependency to 1.17
Date Fri, 03 Aug 2018 10:37:57 GMT
twalthr commented on a change in pull request #6484: [FLINK-9134] [table] upgrade Calcite dependency
to 1.17
URL: https://github.com/apache/flink/pull/6484#discussion_r207497685
 
 

 ##########
 File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogSchema.scala
 ##########
 @@ -106,6 +109,10 @@ class ExternalCatalogSchema(
   def registerSubSchemas(plusOfThis: SchemaPlus) {
     catalog.listSubCatalogs().asScala.foreach(db => plusOfThis.add(db, getSubSchema(db)))
   }
+
+  override def getType(s: String): RelProtoDataType = null
+
+  override def getTypeNames: JSet[String] = ImmutableSet.of()
 
 Review comment:
   We should try to avoid guava. Use `java.util.Collections#unmodifiableSet` instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message