flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] GJL commented on a change in pull request #6464: [FLINK-9936][mesos] WIP
Date Fri, 03 Aug 2018 07:41:12 GMT
GJL commented on a change in pull request #6464: [FLINK-9936][mesos] WIP 
URL: https://github.com/apache/flink/pull/6464#discussion_r207464729
 
 

 ##########
 File path: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManager.java
 ##########
 @@ -391,13 +391,7 @@ private void recoverWorkers(final List<MesosWorkerStore.Worker>
tasksFromPreviou
 
 	@Override
 	public CompletableFuture<Void> postStop() {
-		final CompletableFuture<Void> supportActorsStopFuture = stopSupportingActorsAsync();
-
-		final CompletableFuture<Void> terminationFuture = super.postStop();
-
-		return supportActorsStopFuture.thenCombine(
-			terminationFuture,
-			(Void voidA, Void voidB) -> null);
+		return super.postStop().thenCompose((ignored) -> stopSupportingActorsAsync());
 
 Review comment:
   🤦‍♂️ you are right

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message