flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] GJL commented on a change in pull request #6464: [FLINK-9936][mesos] WIP
Date Fri, 03 Aug 2018 07:27:52 GMT
GJL commented on a change in pull request #6464: [FLINK-9936][mesos] WIP 
URL: https://github.com/apache/flink/pull/6464#discussion_r207462105
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
 ##########
 @@ -734,8 +734,14 @@ private void clearState() {
 		} catch (Exception e) {
 			onFatalError(new ResourceManagerException("Could not properly clear the job leader id
service.", e));
 		}
+		clearState();
 	}
 
+	/**
+	 * Callback to clear state on leadership revocation.
+	 */
+	protected void clearState() {}
 
 Review comment:
   We could also make the interface asynchronous and let the `ResourceManager` handle the
waiting in grant leadership.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message