flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] tillrohrmann commented on a change in pull request #6464: [FLINK-9936][mesos] WIP
Date Thu, 02 Aug 2018 17:06:15 GMT
tillrohrmann commented on a change in pull request #6464: [FLINK-9936][mesos] WIP 
URL: https://github.com/apache/flink/pull/6464#discussion_r207293251
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
 ##########
 @@ -894,17 +900,21 @@ public void grantLeadership(final UUID newLeaderSessionID) {
 
 				// clear the state if we've been the leader before
 				if (getFencingToken() != null) {
-					clearState();
+					clearStateInternal();
 				}
 
 				setFencingToken(newResourceManagerId);
 
 				slotManager.start(getFencingToken(), getMainThreadExecutor(), new ResourceActionsImpl());
 
-				getRpcService().execute(
-					() ->
+				prepareLeadershipAsync()
+					.exceptionally(t -> {
+						onFatalError(t);
+						return null;
+					})
 
 Review comment:
   Let's move the exception handling at the very end. That way we can also catch if `confirmLeaderSessionID`
fails. In all cases, we should call `onFatalError`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message