flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] twalthr commented on a change in pull request #6433: [FLINK-9946][tests] Expose Flink version to E2E tests
Date Wed, 01 Aug 2018 11:53:17 GMT
twalthr commented on a change in pull request #6433: [FLINK-9946][tests] Expose Flink version
to E2E tests
URL: https://github.com/apache/flink/pull/6433#discussion_r206849747
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/common.sh
 ##########
 @@ -36,6 +36,8 @@ export EXIT_CODE=0
 
 echo "Flink dist directory: $FLINK_DIR"
 
+FLINK_VERSION=$(cat ${END_TO_END_DIR}/pom.xml | sed -n 's/[[:blank:]]\+<version>\([a-zA-Z0-9\.-]\+\)<\/version>/\1/p')
 
 Review comment:
   It seems that the `+` causes problems. I searched for it but all I could find was:
   https://unix.stackexchange.com/questions/13711/differences-between-sed-on-mac-osx-and-other-standard-sed
   
   Anyway, `sed -n 's/.*<version>\(.*\)<\/version>/\1/p'` runs fine. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message