flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] zentol commented on a change in pull request #6466: [FLINK-10005][DataStream API] StreamingFileSink: sets initialPartCounter=maxUsed in new Buckets
Date Wed, 01 Aug 2018 07:38:44 GMT
zentol commented on a change in pull request #6466: [FLINK-10005][DataStream API] StreamingFileSink:
sets initialPartCounter=maxUsed in new Buckets
URL: https://github.com/apache/flink/pull/6466#discussion_r206779932
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/Buckets.java
 ##########
 @@ -237,7 +234,7 @@ void onElement(IN value, SinkFunction.Context context) throws Exception
{
 					subtaskIndex,
 					bucketId,
 					bucketPath,
-					initMaxPartCounter,
+					maxPartCounterUsed,
 					partFileWriterFactory);
 			activeBuckets.put(bucketId, bucket);
 		}
 
 Review comment:
   can we add a comment just below that `final PartFileInfo<BucketID> info = bucket.getInProgressPartInfo();`
is `null`  directly after a snapshot and for new empty buckets? This is the detail I was missing
when trying to understand how this fixes the issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message