From issues-return-176825-archive-asf-public=cust-asf.ponee.io@flink.apache.org Thu Jul 12 00:54:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6665A18062A for ; Thu, 12 Jul 2018 00:54:03 +0200 (CEST) Received: (qmail 57633 invoked by uid 500); 11 Jul 2018 22:54:02 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 57620 invoked by uid 99); 11 Jul 2018 22:54:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Jul 2018 22:54:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 1D7DEC0231 for ; Wed, 11 Jul 2018 22:54:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.251 X-Spam-Level: X-Spam-Status: No, score=-109.251 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id oWrlrymVORQL for ; Wed, 11 Jul 2018 22:54:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E882C5F30E for ; Wed, 11 Jul 2018 22:54:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7C8B8E0114 for ; Wed, 11 Jul 2018 22:54:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 38B702713F for ; Wed, 11 Jul 2018 22:54:00 +0000 (UTC) Date: Wed, 11 Jul 2018 22:54:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-9820) Let dynamic properties overwrite configuration settings in ClusterEntrypoint MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-9820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540801#comment-16540801 ] ASF GitHub Bot commented on FLINK-9820: --------------------------------------- GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/6317 [FLINK-9820] Forward dynamic properties to Flink configuration in ClusterEntrypoint ## What is the purpose of the change With this commit we can use dynamic properties to overwrite configuration values in the `ClusterEntrypoint`. This PR is based on #6316. cc @GJL ## Verifying this change - Added `ConfigurationUtilsTest` ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink forwardDynamicPropertiesClusterEntryPoint Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/6317.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6317 ---- commit b798af824433657ca215f8598112094a23819ee0 Author: Till Rohrmann Date: 2018-07-11T15:30:53Z [hotfix] Make PackagedProgram(Class, String...) constructor public commit d373b6b01ec9d5b63513718a8e6b7db87629a477 Author: Till Rohrmann Date: 2018-07-11T15:41:27Z [FLINK-9818] Add cluster component command line parser The cluster component command line parser is responsible for parsing the common command line arguments with which the cluster components are started. These include the configDir, webui-port and dynamic properties. commit 2526bcc69ff4eb3d196a4a7ceba2e59a7f455922 Author: Till Rohrmann Date: 2018-07-09T21:54:55Z [FLINK-9488] Add container entry point StandaloneJobClusterEntryPoint The StandaloneJobClusterEntryPoint is the basic entry point for containers. It is started with the user code jar in its classpath and the classname of the user program. The entrypoint will then load this user program via the classname and execute its main method. This will generate a JobGraph which is then used to start the MiniDispatcher. commit 3b78e4099de1511bbe52c203fd2d05e5cfa03efa Author: Till Rohrmann Date: 2018-07-10T09:24:26Z [FLINK-9819] Add startup scripts for standalone job cluster entry point commit 75fb8125e3ec270994628f46457b281cdb587874 Author: Till Rohrmann Date: 2018-07-10T21:23:59Z [FLINK-9820] Forward dynamic properties to Flink configuration in ClusterEntrypoint With this commit we can use dynamic properties to overwrite configuration values in the ClusterEntrypoint. ---- > Let dynamic properties overwrite configuration settings in ClusterEntrypoint > ---------------------------------------------------------------------------- > > Key: FLINK-9820 > URL: https://issues.apache.org/jira/browse/FLINK-9820 > Project: Flink > Issue Type: Improvement > Components: Distributed Coordination > Affects Versions: 1.6.0 > Reporter: Till Rohrmann > Assignee: Till Rohrmann > Priority: Major > Labels: pull-request-available > Fix For: 1.6.0 > > > The dynamic properties which are passed to the {{ClusterEntrypoint}} should overwrite values in the loaded {{Configuration}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)