From issues-return-177195-archive-asf-public=cust-asf.ponee.io@flink.apache.org Fri Jul 13 08:04:09 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2AD07180626 for ; Fri, 13 Jul 2018 08:04:08 +0200 (CEST) Received: (qmail 94422 invoked by uid 500); 13 Jul 2018 06:04:08 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 94411 invoked by uid 99); 13 Jul 2018 06:04:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Jul 2018 06:04:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id ABF84CF6BD for ; Fri, 13 Jul 2018 06:04:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ULj1Abk6IcAm for ; Fri, 13 Jul 2018 06:04:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id AF9B75FD68 for ; Fri, 13 Jul 2018 06:04:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id EB9BDE25C0 for ; Fri, 13 Jul 2018 06:04:03 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 72F7123FEA for ; Fri, 13 Jul 2018 06:04:02 +0000 (UTC) Date: Fri, 13 Jul 2018 06:04:02 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-9807) Improve EventTimeWindowCheckpointITCase&LocalRecoveryITCase with parameterized MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-9807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542572#comment-16542572 ] ASF GitHub Bot commented on FLINK-9807: --------------------------------------- Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/6305#discussion_r202249510 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/EventTimeWindowCheckpointingITCase.java --- @@ -99,11 +110,21 @@ private AbstractStateBackend stateBackend; + @Parameterized.Parameter + public StateBackendEnum stateBackendEnum; + enum StateBackendEnum { MEM, FILE, ROCKSDB_FULLY_ASYNC, ROCKSDB_INCREMENTAL, ROCKSDB_INCREMENTAL_ZK, MEM_ASYNC, FILE_ASYNC } - protected abstract StateBackendEnum getStateBackend(); + @Parameterized.Parameters(name = "statebackend type ={0}") + public static Collection parameter() { + return Arrays.asList(MEM, FILE, ROCKSDB_FULLY_ASYNC, ROCKSDB_INCREMENTAL, ROCKSDB_INCREMENTAL_ZK, MEM_ASYNC, FILE_ASYNC); --- End diff -- Here we could say `Arrays.asList(StateBackendEnum.values())`. > Improve EventTimeWindowCheckpointITCase&LocalRecoveryITCase with parameterized > ------------------------------------------------------------------------------ > > Key: FLINK-9807 > URL: https://issues.apache.org/jira/browse/FLINK-9807 > Project: Flink > Issue Type: Improvement > Components: Tests > Affects Versions: 1.5.0 > Reporter: Congxian Qiu > Assignee: Congxian Qiu > Priority: Major > Labels: pull-request-available > > Now, the `AbastractEventTimeWIndowCheckpointITCase` and `AbstractLocalRecoveryITCase` need to re-implement for every backend, we can improve this by using JUnit parameterized -- This message was sent by Atlassian JIRA (v7.6.3#76005)