From issues-return-174763-archive-asf-public=cust-asf.ponee.io@flink.apache.org Tue Jul 3 15:58:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A9FDA180718 for ; Tue, 3 Jul 2018 15:58:04 +0200 (CEST) Received: (qmail 67842 invoked by uid 500); 3 Jul 2018 13:58:03 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 67831 invoked by uid 99); 3 Jul 2018 13:58:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jul 2018 13:58:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 5AAC0D1CD0 for ; Tue, 3 Jul 2018 13:58:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id pGX2rDGgsXyt for ; Tue, 3 Jul 2018 13:58:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 288A35F1F3 for ; Tue, 3 Jul 2018 13:58:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 47BF2E10D0 for ; Tue, 3 Jul 2018 13:58:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 842AA27500 for ; Tue, 3 Jul 2018 13:58:00 +0000 (UTC) Date: Tue, 3 Jul 2018 13:58:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-9491) Implement timer data structure based on RocksDB MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-9491?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1653= 1451#comment-16531451 ]=20 ASF GitHub Bot commented on FLINK-9491: --------------------------------------- Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6228#discussion_r199816750 =20 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/In= ternalPriorityQueueTestBase.java --- @@ -0,0 +1,452 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or imp= lied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.state; + +import org.apache.flink.api.common.typeutils.CompatibilityResult; +import org.apache.flink.api.common.typeutils.TypeSerializer; +import org.apache.flink.api.common.typeutils.TypeSerializerConfigSnaps= hot; +import org.apache.flink.core.memory.DataInputView; +import org.apache.flink.core.memory.DataOutputView; +import org.apache.flink.runtime.state.heap.HeapPriorityQueueElement; +import org.apache.flink.util.CloseableIterator; +import org.apache.flink.util.MathUtils; +import org.apache.flink.util.TestLogger; + +import org.junit.Assert; +import org.junit.Test; + +import javax.annotation.Nonnull; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.Comparator; +import java.util.HashSet; +import java.util.Iterator; +import java.util.List; +import java.util.NoSuchElementException; +import java.util.Objects; +import java.util.Set; +import java.util.concurrent.ThreadLocalRandom; + +/** + * Testbase for implementations of {@link InternalPriorityQueue}. + */ +public abstract class InternalPriorityQueueTestBase extends TestLogger= { + +=09protected static final KeyGroupRange KEY_GROUP_RANGE =3D new KeyGro= upRange(0, 2); +=09protected static final KeyExtractorFunction KEY_EXTRAC= TOR_FUNCTION =3D TestElement::getKey; +=09protected static final Comparator TEST_ELEMENT_COMPARA= TOR =3D +=09=09Comparator.comparingLong(TestElement::getPriority).thenComparing= Long(TestElement::getKey); + +=09protected static void insertRandomTimers( +=09=09@Nonnull InternalPriorityQueue priorityQueue, +=09=09@Nonnull Set checkSet, +=09=09int count) { + +=09=09ThreadLocalRandom localRandom =3D ThreadLocalRandom.current(); + +=09=09final int numUniqueKeys =3D Math.max(count / 4, 64); + +=09=09long duplicatePriority =3D Long.MIN_VALUE; + +=09=09for (int i =3D 0; i < count; ++i) { +=09=09=09TestElement element; +=09=09=09do { +=09=09=09=09long elementPriority; +=09=09=09=09if (duplicatePriority =3D=3D Long.MIN_VALUE) { +=09=09=09=09=09elementPriority =3D localRandom.nextLong(); +=09=09=09=09} else { +=09=09=09=09=09elementPriority =3D duplicatePriority; +=09=09=09=09=09duplicatePriority =3D Long.MIN_VALUE; +=09=09=09=09} +=09=09=09=09element =3D new TestElement(localRandom.nextInt(numUniqueK= eys), elementPriority); +=09=09=09} while (!checkSet.add(element)); + +=09=09=09if (localRandom.nextInt(10) =3D=3D 0) { +=09=09=09=09duplicatePriority =3D element.getPriority(); +=09=09=09} + +=09=09=09final boolean headChangedIndicated =3D priorityQueue.add(elem= ent); +=09=09=09if (element.equals(priorityQueue.peek())) { +=09=09=09=09Assert.assertTrue(headChangedIndicated); +=09=09=09} +=09=09} +=09=09Assert.assertEquals(count, priorityQueue.size()); +=09} + +=09@Test +=09public void testPeekPollOrder() { +=09=09final int initialCapacity =3D 4; +=09=09final int testSize =3D 1000; +=09=09InternalPriorityQueue priorityQueue =3D +=09=09=09newPriorityQueue(initialCapacity); +=09=09HashSet checkSet =3D new HashSet<>(testSize); + +=09=09insertRandomTimers(priorityQueue, checkSet, testSize); + +=09=09long lastPriorityValue =3D Long.MIN_VALUE; +=09=09int lastSize =3D priorityQueue.size(); +=09=09Assert.assertEquals(testSize, lastSize); +=09=09TestElement testElement; +=09=09while ((testElement =3D priorityQueue.peek()) !=3D null) { +=09=09=09Assert.assertFalse(priorityQueue.isEmpty()); +=09=09=09Assert.assertEquals(lastSize, priorityQueue.size()); +=09=09=09Assert.assertEquals(testElement, priorityQueue.poll()); +=09=09=09Assert.assertTrue(checkSet.remove(testElement)); +=09=09=09Assert.assertTrue(testElement.getPriority() >=3D lastPriority= Value); +=09=09=09lastPriorityValue =3D testElement.getPriority(); +=09=09=09--lastSize; +=09=09} + +=09=09Assert.assertTrue(priorityQueue.isEmpty()); +=09=09Assert.assertEquals(0, priorityQueue.size()); +=09=09Assert.assertEquals(0, checkSet.size()); +=09} + +=09@Test +=09public void testStopInsertMixKeepsOrder() { --- End diff -- =20 =F0=9F=91=8D=20 > Implement timer data structure based on RocksDB > ----------------------------------------------- > > Key: FLINK-9491 > URL: https://issues.apache.org/jira/browse/FLINK-9491 > Project: Flink > Issue Type: Sub-task > Components: State Backends, Checkpointing > Reporter: Stefan Richter > Assignee: Stefan Richter > Priority: Major > Labels: pull-request-available > Fix For: 1.6.0 > > > We can now implement timer state that is stored in RocksDB for users that= run the {{RocksDBKeyedStateBackend}}. As explained in the design document = (https://docs.google.com/document/d/1XbhJRbig5c5Ftd77d0mKND1bePyTC26Pz04Evx= dA7Jc/edit#heading=3Dh.17v0k3363r6q) this should also give us asynchronous = and incremental snapshots for timer state that is larger than main memory. > We need to think about a way in which to user can select either to run ti= mers on RocksDB or on the heap when using the {{RocksDBKeyedStateBackend}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)