From issues-return-179362-archive-asf-public=cust-asf.ponee.io@flink.apache.org Mon Jul 23 11:29:36 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B43D1180792 for ; Mon, 23 Jul 2018 11:29:35 +0200 (CEST) Received: (qmail 79573 invoked by uid 500); 23 Jul 2018 09:29:34 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 79348 invoked by uid 99); 23 Jul 2018 09:29:34 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Jul 2018 09:29:34 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 3F1F9E08D7; Mon, 23 Jul 2018 09:29:34 +0000 (UTC) From: pnowojski To: issues@flink.apache.org Reply-To: issues@flink.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl ... Content-Type: text/plain Message-Id: <20180723092934.3F1F9E08D7@git1-us-west.apache.org> Date: Mon, 23 Jul 2018 09:29:34 +0000 (UTC) Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6355#discussion_r204330930 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyClientServerSslTest.java --- @@ -65,6 +68,60 @@ public void testValidSslConnection() throws Exception { Channel ch = NettyTestUtil.connect(serverAndClient); + SslHandler sslHandler = (SslHandler) ch.pipeline().get("ssl"); + assertTrue("default value should not be propagated", sslHandler.getHandshakeTimeoutMillis() >= 0); + assertTrue("default value should not be propagated", sslHandler.getCloseNotifyTimeoutMillis() >= 0); + + // should be able to send text data + ch.pipeline().addLast(new StringDecoder()).addLast(new StringEncoder()); + assertTrue(ch.writeAndFlush("test").await().isSuccess()); + + NettyTestUtil.shutdown(serverAndClient); + } + + /** + * Verify valid (advanced) ssl configuration and connection. + */ + @Test + public void testValidSslConnectionAdvanced() throws Exception { --- End diff -- This is quite poor test :( With respect to `SESSION_CACHE_SIZE` and `SESSION_TIMEOUT` it tests only for "not throwing any exception". If those properties are just ignored, the test will still pass. Can we add some stress test that actually verifies the bug which this PR is trying to solve? Maybe stress test AND benchmark like `StreamNetworkThroughputBenchmarkTest#largeRemoteMode`? ---