From issues-return-176064-archive-asf-public=cust-asf.ponee.io@flink.apache.org Mon Jul 9 16:51:51 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8736018077A for ; Mon, 9 Jul 2018 16:51:49 +0200 (CEST) Received: (qmail 60130 invoked by uid 500); 9 Jul 2018 14:51:47 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 59823 invoked by uid 99); 9 Jul 2018 14:51:47 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Jul 2018 14:51:47 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 1FAE2E0C64; Mon, 9 Jul 2018 14:51:47 +0000 (UTC) From: pnowojski To: issues@flink.apache.org Reply-To: issues@flink.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #6264: [FLINK-8558] [table] Add unified format interfaces... Content-Type: text/plain Message-Id: <20180709145147.1FAE2E0C64@git1-us-west.apache.org> Date: Mon, 9 Jul 2018 14:51:47 +0000 (UTC) Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6264#discussion_r200998882 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSourceFactoryService.scala --- @@ -139,9 +139,14 @@ object TableSourceFactoryService extends Logging { Seq[String]() } + // extract wildcard prefixes --- End diff -- please extract at least both `// extract wildcard prefixes` and `// check for supported properties` into separate method (this method is already too large) ---