flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9987) Rework ClassLoaderITCase to not rely on .version.properties file
Date Fri, 27 Jul 2018 16:28:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559969#comment-16559969
] 

ASF GitHub Bot commented on FLINK-9987:
---------------------------------------

zentol opened a new pull request #6442: [FLINK-9987][tests] Harden ClassLoader E2E test
URL: https://github.com/apache/flink/pull/6442
 
 
   ## What is the purpose of the change
   
   This PR hardens the ClassLoader end-to-end test.
   
   ## Brief change log
   
   * retrieve commit id from `.version.properties` as the value has a well-defined format
   * do not access `.version.properties` file in source of flink-runtime and match id against
regex instead
     * prevents failures caused by value mismatches if the binary does not originate from
the source
     * prevents failures when flink-runtime has not been built, e.g. if the tests were run
in a clean repo
     * removes access outside of `flink-end-to-end-tests` which is good for maintainability
   * exit early on test failure
     * same behavior as if the test was split in several files
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Rework ClassLoaderITCase to not rely on .version.properties file
> ----------------------------------------------------------------
>
>                 Key: FLINK-9987
>                 URL: https://issues.apache.org/jira/browse/FLINK-9987
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 1.5.0, 1.6.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>
> The classloading end-to-end test makes use of the {{.version.properties}} file that is
bundled with flink-runtime to ensure classloading works properly.
> In particular it access the {{git.remote.origin.url}} property.
> This should be changed since this property isn't stable across builds, which results
in test failures when running the e2e tests against a release that was built on a different
machine.
> The test furthermore relies on this file also existing in the source flink-runtime module,
which is a dangerous assumption as this requires flink-runtime to be built beforehand. It
is also _yet another_ instance where we navigate out of a module which should never be done.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message