flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9885) End-to-end test: Elasticsearch 6.x connector
Date Wed, 25 Jul 2018 06:58:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555244#comment-16555244
] 

ASF GitHub Bot commented on FLINK-9885:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6391#discussion_r204758828
  
    --- Diff: flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java
---
    @@ -176,7 +175,7 @@ public void setDelayMillis(long delayMillis) {
     	private AtomicLong numPendingRequests = new AtomicLong(0);
     
     	/** Elasticsearch client created using the call bridge. */
    -	private transient Client client;
    +	private transient AutoCloseable client;
    --- End diff --
    
    Same here. Why not parameterize the class and be type save?


> End-to-end test: Elasticsearch 6.x connector
> --------------------------------------------
>
>                 Key: FLINK-9885
>                 URL: https://issues.apache.org/jira/browse/FLINK-9885
>             Project: Flink
>          Issue Type: Sub-task
>          Components: ElasticSearch Connector, Tests
>            Reporter: Tzu-Li (Gordon) Tai
>            Assignee: Tzu-Li (Gordon) Tai
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>
> We have decided to try and merge the pending Elasticsearch 6.x PRs. This should also
come with an end-to-end test that covers this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message