flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9862) Update end-to-end test to use RocksDB backed timers
Date Mon, 23 Jul 2018 09:26:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552540#comment-16552540
] 

ASF GitHub Bot commented on FLINK-9862:
---------------------------------------

Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6351#discussion_r204336026
  
    --- Diff: flink-end-to-end-tests/flink-datastream-allround-test/src/main/java/org/apache/flink/streaming/tests/SequenceGeneratorSource.java
---
    @@ -197,6 +210,11 @@ public void initializeState(FunctionInitializationContext context)
throws Except
     			for (KeyRangeStates keyRange : snapshotKeyRanges.get()) {
     				keyRanges.add(keyRange);
     			}
    +
    +			// let event time start from the max of all event time progress across subtasks in
the last execution
    +			for (Long lastEventTime : lastEventTimes.get()) {
    +				monotonousEventTime = Math.max(monotonousEventTime, lastEventTime);
    --- End diff --
    
    I wonder why we compute the event time as the max and not as the min, as we would usually
do for a combined watermark. This is probably never rescaled anyways, but still it looks a
bit suspicious.


> Update end-to-end test to use RocksDB backed timers
> ---------------------------------------------------
>
>                 Key: FLINK-9862
>                 URL: https://issues.apache.org/jira/browse/FLINK-9862
>             Project: Flink
>          Issue Type: Sub-task
>          Components: State Backends, Checkpointing, Streaming
>    Affects Versions: 1.6.0
>            Reporter: Till Rohrmann
>            Assignee: Tzu-Li (Gordon) Tai
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>
> We should add or modify an end-to-end test to use RocksDB backed timers.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message