flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9852) Expose descriptor-based sink creation in table environments
Date Tue, 17 Jul 2018 10:13:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546316#comment-16546316
] 

ASF GitHub Bot commented on FLINK-9852:
---------------------------------------

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6343#discussion_r202963074
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalTableUtil.scala
---
    @@ -0,0 +1,148 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.catalog
    +
    +import java.util
    +
    +import org.apache.flink.table.api._
    +import org.apache.flink.table.descriptors.DescriptorProperties
    +import org.apache.flink.table.factories._
    +import org.apache.flink.table.plan.schema._
    +import org.apache.flink.table.plan.stats.FlinkStatistic
    +import org.apache.flink.table.util.Logging
    +
    +
    +/**
    +  * The utility class is used to convert [[ExternalCatalogTable]] to [[TableSourceSinkTable]].
    +  *
    +  * It uses [[TableFactoryService]] for discovering.
    +  */
    +object ExternalTableUtil extends Logging {
    +
    +  /**
    +    * Converts an [[ExternalCatalogTable]] instance to a [[TableSourceTable]] instance
    +    *
    +    * @param externalCatalogTable the [[ExternalCatalogTable]] instance which to convert
    +    * @return converted [[TableSourceTable]] instance from the input catalog table
    +    */
    +  def fromExternalCatalogTable[T1, T2](
    +      tableEnv: TableEnvironment,
    +      externalCatalogTable: ExternalCatalogTable)
    +    : TableSourceSinkTable[T1, T2] = {
    +
    +    val properties = new DescriptorProperties()
    +    externalCatalogTable.addProperties(properties)
    +    val javaMap = properties.asMap
    +    val statistics = new FlinkStatistic(externalCatalogTable.getTableStats)
    +
    +    val source: Option[TableSourceTable[T1]] = tableEnv match {
    +      // check for a batch table source in this batch environment
    --- End diff --
    
    drop those comments, code is already self explanatory 


> Expose descriptor-based sink creation in table environments
> -----------------------------------------------------------
>
>                 Key: FLINK-9852
>                 URL: https://issues.apache.org/jira/browse/FLINK-9852
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API &amp; SQL
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>            Priority: Major
>              Labels: pull-request-available
>
> Currently, only a table source can be created using the unified table descriptors with
{{tableEnv.from(...)}}. A similar approach should be supported for defining sinks or even
both types at the same time.
> I suggest the following syntax:
> {code}
> tableEnv.connect(Kafka(...)).registerSource("name")
> tableEnv.connect(Kafka(...)).registerSink("name")
> tableEnv.connect(Kafka(...)).registerSourceAndSink("name")
> {code}
> A table could then access the registered source/sink.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message