flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9846) Add a Kafka table sink factory
Date Mon, 23 Jul 2018 10:46:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552641#comment-16552641
] 

ASF GitHub Bot commented on FLINK-9846:
---------------------------------------

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6387#discussion_r204347924
  
    --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSink.java
---
    @@ -40,27 +45,68 @@
     @Internal
     public abstract class KafkaTableSink implements AppendStreamTableSink<Row> {
     
    +	// TODO make all attributes final and mandatory once we drop support for format-specific
table sinks
    +
    +	/** The schema of the table. */
    +	private final Optional<TableSchema> schema;
    +
    +	/** The Kafka topic to write to. */
     	protected final String topic;
    +
    +	/** Properties for the Kafka producer. */
     	protected final Properties properties;
    -	protected SerializationSchema<Row> serializationSchema;
    +
    +	/** Serialization schema for encoding records to Kafka. */
    +	protected Optional<SerializationSchema<Row>> serializationSchema;
    +
    +	/** Partitioner to select Kafka partition for each item. */
     	protected final FlinkKafkaPartitioner<Row> partitioner;
    +
    +	// legacy variables
     	protected String[] fieldNames;
     	protected TypeInformation[] fieldTypes;
     
    +	/**
    --- End diff --
    
    Please drop this java doc or fields java docs.
    1. This is not public method
    2. it duplicates the docs of the fields
    3. fields/params are on their own self explanatory (I have no problem understanding them
on their own)
    
    For that matter I would drop both of those java docs, but keeping two of them is an overkill


> Add a Kafka table sink factory
> ------------------------------
>
>                 Key: FLINK-9846
>                 URL: https://issues.apache.org/jira/browse/FLINK-9846
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API &amp; SQL
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>            Priority: Major
>              Labels: pull-request-available
>
> FLINK-8866 implements a unified way of creating sinks and using the format discovery
for searching for formats (FLINK-8858). It is now possible to add a Kafka table sink factory
for streaming environment that uses the new interfaces.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message